Uploaded October 2021 | Updated September 2026, 3 weeks ago
This is the 83rd video in the NerdDice create a RubyGem series. In this video Mike opens a pull request reviews the code that is included. Comments are added, edited and clarified for the ConvenienceMethods module. In addtion, while commenting, he looks for opportunites to improve the code via removal of unnecessary code and improves the error message for the bonus integrity failure situation.
This video covers:
00:00:12 Introduction
00:00:59 Open a pull request to master
00:02:13 Review changed files in the pull request
00:02:24 Start working on commenting convenience_methods.rb
00:03:12 Remove guard statements that are never used
00:04:44 Remove extraneous local variable assignment
00:05:23 Review comments so far
00:06:08 Remove unused parameter in get_number_of_dice_from_method_name
00:07:25 Improve error message for bonus integrity failure
00:08:35 Fix RSpec failures caused by changing error message in one spec file
00:11:18 Create method in spec_helper to handle bonus error message
00:14:14 Apply bonus error message changes to other specs
00:16:18 The tedious task of commenting all the specs
00:21:06 Commit, push, review changes, update backlog
This video is CC0 - No rights reserved. (YouTube doesn't allow this option when publishing.) All code is released under the UNLICENSE. Stateless Code denies the concept of "intellectual property". Copying is not stealing.
This is the 83rd video in the NerdDice create a RubyGem series. In this video Mike opens a pull request reviews the code that is included. Comments are added, edited and clarified for the ConvenienceMethods module. In addtion, while commenting, he looks for opportunites to improve the code via removal of unnecessary code and improves the error message for the bonus integrity failure situation.
This video covers:
00:00:12 Introduction
00:00:59 Open a pull request to master
00:02:13 Review changed files in the pull request
00:02:24 Start working on commenting convenience_methods.rb
00:03:12 Remove guard statements that are never used
00:04:44 Remove extraneous local variable assignment
00:05:23 Review comments so far
00:06:08 Remove unused parameter in get_number_of_dice_from_method_name
00:07:25 Improve error message for bonus integrity failure
00:08:35 Fix RSpec failures caused by changing error message in one spec file
00:11:18 Create method in spec_helper to handle bonus error message
00:14:14 Apply bonus error message changes to other specs
00:16:18 The tedious task of commenting all the specs
00:21:06 Commit, push, review changes, update backlog
This video is CC0 - No rights reserved. (YouTube doesn't allow this option when publishing.) All code is released under the UNLICENSE. Stateless Code denies the concept of "intellectual property". Copying is not stealing.
